rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision.
REVISION SUMMARY The file dialog allows to move the file name labels from next to the icon to right under the icon for Short View. However, having to go in a deeply nested Settings button > Icon Position > Above File Name submenu makes it both hard to discover and cumbersome to use. Ideally this setting could be accessed directly from the menu for good usability. Making it easy to change back settings is especially important in light of D12326 <https://phabricator.kde.org/D12326>, which will enable Icons Above File Name by default. We linearize the submenu entries from the submenu to the top-level menu, which works just fine as there are only two entries, increasing the overall menu size by only one item while removing an entire submenu. While the submenu itself is not advertised in the API docs, it was publicly accessible, and therefore is kept for compatiblity reasons (although with a slight change in wording). Ref T8552 <https://phabricator.kde.org/T8552> FIXED-IN: 5.47 TEST PLAN `kdialog --getopenfilename`, switch view modes via the settings button, check that the icon position settings are only enabled for View > Short View and still work properly. Before: F5826732: KIO-icon-position-before.png <https://phabricator.kde.org/F5826732> After: F5826733: KIO-icon-position-after.png <https://phabricator.kde.org/F5826733> REPOSITORY R241 KIO BRANCH icon-position-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D12591 AFFECTED FILES src/filewidgets/kdiroperator.cpp src/filewidgets/kfilewidget.cpp To: rkflx, #frameworks Cc: michaelh, bruns