elvisangelaccio added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12-13
> +)
> +install(TARGETS purposefileitemaction DESTINATION ${PLUGIN_INSTALL_DIR})
> +install(FILES purposesendfile.desktop DESTINATION ${SERVICES_INSTALL_DIR})

Please consider using json metadata and installing the plugin into the 
`kf5/kfileitemaction` namespace.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

Reply via email to