elvisangelaccio added inline comments.
INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:12-13
> Sorry, I don't quite understand what I am supposed to do
I recommend to use the `kcoreaddons_add_plugin` cmake macro. Something like
this:
kcoreaddons_add_plugin(purposefileitemaction
SOURCES sendfileitemaction.cpp
JSON sendfileitemaction.json
INSTALL_NAMESPACE "kf5/kfileitemaction")
then drop both the `install()` calls.
Also, the plugin should use `K_PLUGIN_FACTORY_WITH_JSON` rather than
`K_PLUGIN_FACTORY`.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D13124
To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol,
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef,
andrebarros, bruns, emmanuelp
