shubham updated this revision to Diff 38852. shubham added a comment.
Remove helper function isIconEditable() (wasn't required), the check can directly be carried out in if clause for dialog->m_iconButton REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38824&id=38852 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED FILES src/filewidgets/kfileplaceeditdialog.cpp To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
