pino added a comment.
In D14360#301270 <https://phabricator.kde.org/D14360#301270>, @cfeck wrote: > I still would like to understand why it needs to be public API, instead of just an `@internal` method. This is not a public API, since `KFilePlaceEditDialog` is a private class which is not even exported. INLINE COMMENTS > kfileplaceeditdialog.cpp:65 > label = dialog->label(); > - icon = dialog->icon(); > + if (dialog->m_iconButton) { > + icon = dialog->icon(); This is even worse than the method. Please switch back to the method, since it is the better solution, REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
