cfeck added inline comments. INLINE COMMENTS
> ngraham wrote in atticaprovider.cpp:280 > Also isn't Qt `foreach` deprecated anyway? > https://www.kdab.com/goodbye-q_foreach/ Ah, yes. `Q_FOREACH`, or C++11 `for (x : y)` if you see it does not cause unneeded detaches. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent Cc: cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns