leinir marked 16 inline comments as done. leinir added a comment.
i guess uncrustify isn't a magic bullet either, eh? ;) Thanks for the findings! INLINE COMMENTS > cfeck wrote in khotnewstuff_test.cpp:66 > Any rationale for using `fromLocal8Bit()` for fixed strings? If, for whatever > reason, you do not want to use QStringLiteral or QLatin1String, please use > fromUtf8(). This is what we ship for source files. None apart from this being a modified version of an old test which used that function rather than the proper one. Fixed :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns