dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land.
Looks good to me. Related: in order to have better unit testing, would you be willing to add a unit test to https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_test.cpp called void testJsonData() { ... } This test would iterate over all themes via Qt Resources and check wether all 31 default text styles exist, and also check for the existence of the editor colors. This would help us to catch theme issues early in the future. Feel free to commit this patch now. REPOSITORY R216 Syntax Highlighting BRANCH add-solarized-themes REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars
