acrouthamel added a comment.
In D15340#322112 <https://phabricator.kde.org/D15340#322112>, @dhaumann wrote: > Looks good to me. > > Related: in order to have better unit testing, would you be willing to add a unit test to https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_test.cpp called > > void testJsonData() { ... } > > > This test would iterate over all themes via Qt Resources and check wether all 31 default text styles exist, and also check for the existence of the editor colors. This would help us to catch theme issues early in the future. > > Feel free to commit this patch now. Thanks! I would be glad to add that, but I honestly have no idea how to do so. I'm just starting out. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars
