jtamate added a comment.

  What would happen if finishNotification is called twice, In line 161 and then 
in line 192? 
  My guess is that finished signal will be called twice with the same 
notification, and therefore KNotificationManager::notifyPluginFinished will be 
called twice. I don't know what will happen the second time.
  Perhaps a return after line 161 is needed?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15638

To: sitter, broulik
Cc: kde-frameworks-devel, jtamate, michaelh, ngraham, bruns

Reply via email to