jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land.
Forget what I just wrote. I've seen that I was missing 15 lines in between then in the phabricator diff view. :-( Looks good to me. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D15638 To: sitter, broulik, jtamate Cc: kde-frameworks-devel, jtamate, michaelh, ngraham, bruns