bruns added a comment.
In D15583#330799 <https://phabricator.kde.org/D15583#330799>, @smithjd wrote: > Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work: > > if (folder.startsWith(path)) > > > This doesn't prevent the user from also re-specifying valid paths. Exact matches are already rejected in the block above. `folder.startsWith(path)` is also pointless, a user should be allowed to e.g. exclude `<home>/foo/` if `<home>/foo/bar/baz is excluded and `<home>/foo/bar` is REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams