davidedmundson added inline comments. INLINE COMMENTS
> dialog.cpp:209 > + QWindow *parentWindow = q->transientParent(); > + bool inDock = parentWindow && !parentWindow->mask().isNull() && > KWindowSystem::compositingActive(); > + How does parentWindow->mask relate to being a dock or not? Also we need to be a bit careful on names. _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns