bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:91
> Do I understand correctly, that's a binary-search-like way to find the file 
> actually causing `extractor` to crash, and it will reindex some of the files 
> in a batch ~log2(batchsize) times?
> Why don't we rely instead on its progress reporting, via 
> `startedIndexingFile` / `finishedIndexingFile`?

Yes, its a binary search.
Because we only have IDs here, and the progress reporting works on strings.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

Reply via email to