bruns marked 3 inline comments as done.
bruns added inline comments.


> poboiko wrote in filecontentindexer.cpp:91
> There is `Transaction::documentId(const QByteArray& path)`, which can resolve 
> it using `DocumentUrlDB`.
> I believe it still would be cheaper than reindexing several files multiple 
> times.

But it is racy - if the file is replaced in the meantime, inode and filename no 
longer match. This is not completely unlikely when dealing with temporary files.

It would make the code also significantly more complex, and I want it simple 
here. It should only be hit in exceptional cases.

Also, it is not to uncommon to have a batch of size one from the start, i.e. 
when adding/modifying files.

  R293 Baloo


To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

Reply via email to