leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision.
REVISION SUMMARY Previously, KNSCore only signalled errors using string messages, which were useful for fault finding, but not useful when attempting to handle errors during general operation. This patch adds a signal which is fired at the same time as some error messages, and which provides error condition information which is useful in a programmatical fashion. This patch would allow https://bugs.kde.org/show_bug.cgi?id=395937 to be fixed in a non-hackish fashion. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 AFFECTED FILES src/attica/atticaprovider.cpp src/core/CMakeLists.txt src/core/engine.cpp src/core/engine.h src/core/errorcode.h src/core/provider.h To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns