leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in engine.h:430
> I would include the error message here and deprecate `signalError`. Otherwise 
> it's going to be a mess matching both signals.

Quite a good point, yes - i've done a bit of jiggling around, new patch incoming

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

Reply via email to