pranavgade added inline comments. INLINE COMMENTS
> jgrulich wrote in macsecsettingtest.cpp:29 > This required version is not true, please verify it properly, I'm not going > to do it every time :). I tried to get the version from here: F6459587: Screenshot from 2018-12-06 22-13-34.png <https://phabricator.kde.org/F6459587> Is that incorrect? If so, from where do I check the version? > jgrulich wrote in macsecsetting.h:58 > Can be turned into an enum. From where can I get the possible values? Because I cannot find them here: https://developer.gnome.org/NetworkManager/stable/settings-macsec.html REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns