ltoscano added a comment.
In D17500#376854 <https://phabricator.kde.org/D17500#376854>, @astippich wrote: > In D17500#376221 <https://phabricator.kde.org/D17500#376221>, @aacid wrote: > > > In D17500#375753 <https://phabricator.kde.org/D17500#375753>, @astippich wrote: > > > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( > > > Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite KIO-specific, and a quick look at lxr didn't reveal any usages of the thumbnailer. > > > > > > Why would it be part of kio-extras? the beauty of plugins is that they can live wherever, no? > > > My thinking here was that a lot of other thumbnailers are located in kio-extras. Moving the thumbnailer there too would lift the KIO dependency and make qmobipocket easier to deploy and to be used by others. Just a note about this: kio-extras was not meant to be a collector of all possible kios. It's becaming as such, but if this continues we may end up revisiting it and splitting it. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
