loh.tar updated this revision to Diff 47891. loh.tar added a comment.
- Workaround to keep binary compatibility > It's exported class you cannot... Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ? - Seams still to work so far, but looks not so lovely - Fixed (hopefully) as described there https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#Trouble_shooting - Some functions have now no implementation, is that a problem? - Some new function could be avoided and an old one used, but that would reduce the readability CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47843&id=47891 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp src/search/katesearchbar.h src/search/searchbarpower.ui To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann