cullmann added a comment.
I am a bit confused which questions still need answers ;=) What I think about the current state of the patch: I am fine with it, beside that I think having the dictionary picker per default there takes to much space and one should have some "show XXX" in the context menu for it. I am fine with doing it all in one patch and I have no issues with the other changes. For the "should we use buttons": I think I tried that in the past and it did look horrible in many styles, but perhaps I am wrong ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
