bruns added inline comments. INLINE COMMENTS
> valeriymalov wrote in documentdatadb.cpp:107 > Trying to delete a non-existent entry seems like an error to me Deleting is an idempotent operation, so e.g. doing it twice is fine. There may be multiple events queued leading to the deletion of a database entry, i.e. deleting a file and then deleting a parent directory recursively. > bruns wrote in postingdb.cpp:232 > //critical - You are leaking the cursor now// not done ... you have to always `mdb_cursor_close` Also, MDB_NOTFOUND is not an error here. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
