poboiko added a comment.
I've looked through the patch (quite large indeed), apart from the single
note I think it's good to go.
INLINE COMMENTS
> postingdb.cpp:238
> mdb_cursor_close(cursor);
> - if (termIterators.isEmpty()) {
> + if (rc || termIterators.isEmpty()) {
> return nullptr;
Can it happen that `rc == MDB_NOTFOUND` just after some iterations of
`MDB_NEXT` operation (i.e. we've reached the end of DB), but keys which popped
up previously are perfectly valid, and we're just ignoring them here?
(shouldn't it read `rc != 0 && rc != MDB_NOTFOUND`, just like above?)
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D18664
To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, domson,
ashaposhnikov, michaelh, astippich, spoorun, abrahams
