sitter added a comment.
LGTM technically. Also looks crazy scary invasive though from a packaging POV :O What if a third party user of kpackage actively relied on the appstream data being auto-generated? Wouldn't this change in behavior essentially break backwards compatibility? Perhaps it'd be less scary if ECM's KDECmakeSettings set some var to make KDE software default-opt-out of autogeneration (and then revisit the default behavior for the macro for KF6)? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns
