ngraham added a comment.
In D19850#439332 <https://phabricator.kde.org/D19850#439332>, @sitter wrote: > LGTM technically. Also looks crazy scary invasive though from a packaging POV :O > > What if a third party user of kpackage actively relied on the appstream data being auto-generated? Then they'd basically be doing it wrong since you're supposed to actually put some effort into creating the appdata file yourself. :) > Perhaps it'd be less scary if ECM's KDECmakeSettings set some var to make KDE software default-opt-out of autogeneration (and then revisit the default behavior for the macro for KF6)? No strong objection. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns
