bruns added inline comments. INLINE COMMENTS
> file.cpp:890 > + break; > + default: // case 0: > + // filename, access, type, size, linkdest This is wrong in case someone uses details > 3, should be `case 0: reserve(5)`, `case 3: default: reserve(15)` . all checks below do e.g `if (details > 2)`, so handle 5 the same as 3. > file.cpp:939 > + #endif > + auto bufferSize = qBound(lowerBound, size +1, higherBound); > QByteArray linkTargetBuffer; missing space, `size + 1` REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
