meven added a comment.
There is still a couple raw QT_LSTAT in KFileItem https://cgit.kde.org/kio.git/tree/src/core/kfileitem.cpp#n224 . Do you think we should apply the same kind of solution there, with #idef ? I would be in favor of reusing code instead. Eventually moving FileProtocol::createUDSEntry out of FileProtocol in some other util so that it can be reused by KFileitem. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns