jglogowski added a comment.
In D21249#467037 <https://phabricator.kde.org/D21249#467037>, @dfaure wrote: > A unittest addition would be good, too. Done In D21249#467073 <https://phabricator.kde.org/D21249#467073>, @dfaure wrote: > Yes, naming is hard because the method is dual-purposed ;-) > > If the method only tried to match (but not to set), then the naming would be much simpler. … Done > > >> It "felt" strange, but I don't care much. > > I do care, because others will try to understand and possibly modify this code later, so it should not "feel strange". I should have written. "Fine with me.". No offense intended. INLINE COMMENTS > dfaure wrote in kfilewidget.cpp:2495 > You wrote "done", but it's still there. Should have been - will do. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns
