dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Thanks! One minor issue: unittests (those based on QTEST_MAIN like yours) go into the autotests directory. tests/ is for interactive test programs. Can you move it there? It could even be just a new method in the existing autotests/kfilewidgettest.cpp [if you do keep it separate for some reason, add a copyright header, but my recommendation is to merge it anyway, to keep the usual structure of one test file per class being tested] REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns
