cullmann added a comment.
Coding style wise, could one change: 1. this->XXX() => XXX() 2. void functions should not have "return;" at the end, we don't do that REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking, sars