feverfew added inline comments.
INLINE COMMENTS
> apol wrote in file.cpp:520
> this should be
>
> {
> Q_EMIT data({});`
> return;
> }
>
> I'm not sure that we'd need an empty data emitted then. Are you trying to fix
> a specific bug that triggers this?
I('ve not seen any IOSlave use a Q_EMIT macro, any reason why it's necessary
here (what's the change in the behaviour).
Please re-read the summary, carefully, the error is subtle.
> apol wrote in file.cpp:526
> alternatively this could also check ` && bytes != 0`
Please reread the summary, this would not fix the bug.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23159
To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
