feverfew added inline comments. INLINE COMMENTS
> chinmoyr wrote in file.cpp:524 > This doesn't support error reporting. Why not refactor this loop using > read(char *, qint64)? I believe you can accommodate your changes inside the > loop cleanly then. I think that would be appropriate for a separate revision which I'm doing. This revision is only to handle the case outlined in the summary. > chinmoyr wrote in file.cpp:538 > here `bytes` being negative should be an error..no? bytes is unsigned, so it is not a worry for us. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23159 To: feverfew, dfaure, fvogt, chinmoyr Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
