davidedmundson added a comment.
Looks good to me
INLINE COMMENTS
> kcoreconfigskeleton.cpp:140
> +{
> + return d->mIsDefaultImpl();
> +}
Do we need to make this
if (d->mIsDefaultImpl){
return d->mIsDefaultImpl();
}
return false;
and initialize mIsDefaultImpl to nullptr
so that it doesn't crash if someone subclasses KConfigSkeletonItem directly and
doesn't implement this?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D24494
To: ervin, #plasma, #frameworks, dfaure, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
