ahmadsamir updated this revision to Diff 70271. ahmadsamir marked 8 inline comments as done. ahmadsamir retitled this revision from "More (and last) fixes to compile without implicit conversion from ASCII/ByteArray" to "More fixes to compile without implicit conversion from ASCII/ByteArray". ahmadsamir added a comment.
Address review comments. Rebase, and fix some more instances of casting from ASCII that crept up since the diff was created. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24349?vs=67151&id=70271 BRANCH arcpatch-D24349 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24349 AFFECTED FILES src/core/forwardingslavebase.cpp src/core/kremoteencoding.cpp src/core/slavebase.cpp src/core/slavebase.h src/filewidgets/kencodingfiledialog.cpp src/filewidgets/kfileplacesmodel.cpp src/ioslaves/ftp/CMakeLists.txt src/ioslaves/ftp/ftp.cpp src/kcms/kio/kcookiespolicies.cpp src/kcms/kio/smbrodlg.cpp src/kioexec/main.cpp src/kpasswdserver/autotests/CMakeLists.txt src/kpasswdserver/autotests/kpasswdservertest.cpp To: ahmadsamir, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
