ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> Dialog.qml:55
> property string downloadNewWhat: engine.name
> - title: i18n("Download New %1", component.downloadNewWhat)
> + title: i18n("Download New %1", (component.downloadNewWhat.length > 0 ?
> component.downloadNewWhat : i18nc("Used to contruct the dialog's title (which
> will become Download New Stuff)", "Stuff")))
>
For readability's sake and to avoid nested `i18n()` calls which would cause
string puzzles, I would do it like this:
title: component.downloadNewWhat.length === 0 ? i18n("Download new stuff"):
i18n("Download New %1," component.downloadNewWhat)
also "stuff" lol
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D25849
To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
