ahmadsamir requested review of this revision. ahmadsamir added a comment.
IINM, fileNameOnly() can be safely deleted; it's only used once on line 2226: fileNameOnly(baseName) and baseName is initialised on line 1630: QString baseName = QFileInfo(codegenFilename).fileName(); so it's the filename only, excluding the path, so it'll never have / or \ in it, IIUC. And the fact it's been broken at least since the kdelibs split in 2013. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
