ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kconfig_compiler.cpp:646
> I wonder if qMax(path.lastIndexOf('/'), path.lastIndexOf('\\')) wouldn't be
> simpler and faster :-)
>
> But yes you're right, might as well just delete this function.
> I bet someone didn't realize, LONG ago, that even on Windows, Qt uses '/' in
> almost all of the API.
Yep; (and who knows if Qt docs were as expansive/exhaustive as they're now :)).
And then fileNameOnly() became unneeded when QFileInfo was used in the code.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26177
To: ahmadsamir, #frameworks, dfaure, ervin, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
