> On 2010-11-08 07:22:30, Kevin Ottens wrote: > > /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp, line 103 > > <http://svn.reviewboard.kde.org/r/5729/diff/2/?file=40677#file40677line103> > > > > OK, seeing that one again I know what was bugging me, it shouldn't be > > necessary for you to pass a service name (and also in the case you don't > > pass it it makes your implementation flacky I guess as on the application > > crash you couldn't auto-release). > > > > Now, all the D-Bus services have an address even though they don't have > > a registered name. So really you shouldn't need to pass this name IMO. > > > > On the implementer side you could use QDBusContext to find out who was > > the sender of the message, it'll be much more reliable (one could lie to > > you right now, and also as I pointed out above in some cases you wouldn't > > have a registered name).
You are right: for any reason, I totally forgot about this feature. - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5729/#review8546 ----------------------------------------------------------- On 2010-11-06 15:32:55, Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5729/ > ----------------------------------------------------------- > > (Updated 2010-11-06 15:32:55) > > > Review request for Solid and Kevin Ottens. > > > Summary > ------- > > With recent commits in kdebase/workspace/powerdevil, the KDE Power Management > System has gained a new shiny PolicyAgent for handling inhibition requests, > now with the killer feature of suppressing screen power management as well. > This patch adds 2 more methods to Solid::PowerManagement and the DBus > interface for the policy agent. If the patch will be accepted, the interface > will be of course removed from powerdevil/, given that it is installed from > within kdelibs. > > > Diffs > ----- > > /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1193618 > > /trunk/KDE/kdelibs/solid/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml > PRE-CREATION > /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1193618 > /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1193618 > /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1193618 > > Diff: http://svn.reviewboard.kde.org/r/5729/diff > > > Testing > ------- > > > Thanks, > > Dario > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
