-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5729/#review8570
-----------------------------------------------------------

Ship it!


Good to go now. Nice job!

- Kevin


On 2010-11-08 09:08:57, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5729/
> -----------------------------------------------------------
> 
> (Updated 2010-11-08 09:08:57)
> 
> 
> Review request for Solid and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> With recent commits in kdebase/workspace/powerdevil, the KDE Power Management 
> System has gained a new shiny PolicyAgent for handling inhibition requests, 
> now with the killer feature of suppressing screen power management as well. 
> This patch adds 2 more methods to Solid::PowerManagement and the DBus 
> interface for the policy agent. If the patch will be accepted, the interface 
> will be of course removed from powerdevil/, given that it is installed from 
> within kdelibs.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1194086 
>   
> /trunk/KDE/kdelibs/solid/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml 
> PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1194086 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1194086 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1194086 
> 
> Diff: http://svn.reviewboard.kde.org/r/5729/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario
> 
>

_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to