> On Sept. 3, 2013, 12:43 a.m., Lamarque Souza wrote: > > modemgsmcardinterface.cpp, line 94 > > <http://git.reviewboard.kde.org/r/112472/diff/1/?file=186634#file186634line94> > > > > You should avoid using QDBusReply and waitForFinished(). If operator id > > is a property updated by the propertiesChanged signal then you should cache > > its value and return the cached value here. > > Anant Kamath wrote: > It's not a property. It calls GetOperatorId() on the dbus iface.
The rest of libmm-qt in master is not implementing caching/non-blocking dbus calls, so I just followed the exisiting pattern here. (mm08 has these done correctly) - Anant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112472/#review39223 ----------------------------------------------------------- On Sept. 2, 2013, 9:54 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112472/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 9:54 p.m.) > > > Review request for Solid and Lamarque Souza. > > > Description > ------- > > Upgraded ModemGsmCardInterface to the MM 0.5 (atleast 0.5) spec. > > > Diffs > ----- > > dbus/introspection/mm-modem-gsm-card.xml e35821a > dbus/mm-modem-gsm-cardinterface.h 35f2dc4 > dbus/mm-modem-gsm-cardinterface.cpp 6bc2dc0 > modemgsmcardinterface.h 5f56a85 > modemgsmcardinterface.cpp 80d0a9c > > Diff: http://git.reviewboard.kde.org/r/112472/diff/ > > > Testing > ------- > > Builds, works. > > > Thanks, > > Anant Kamath > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
