----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112472/#review39532 -----------------------------------------------------------
modemgsmcardinterface.cpp <http://git.reviewboard.kde.org/r/112472/#comment29133> I know, I implemented libmm-qt years ago. By the time I did not know the problems that using synchronous API could cause in plasma-desktop. We should not repeat the same mistake now, ok? Just return the QDBusPendingReply<QString> returned by the d->modemGsmCardIface.GetOperatorId() call and let the user decice if he/she wants to use the synchronous or asynchronous API. We should not force a synchronous API here. The same is valid for getSpn() below. - Lamarque Souza On Sept. 2, 2013, 9:54 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112472/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 9:54 p.m.) > > > Review request for Solid and Lamarque Souza. > > > Description > ------- > > Upgraded ModemGsmCardInterface to the MM 0.5 (atleast 0.5) spec. > > > Diffs > ----- > > dbus/introspection/mm-modem-gsm-card.xml e35821a > dbus/mm-modem-gsm-cardinterface.h 35f2dc4 > dbus/mm-modem-gsm-cardinterface.cpp 6bc2dc0 > modemgsmcardinterface.h 5f56a85 > modemgsmcardinterface.cpp 80d0a9c > > Diff: http://git.reviewboard.kde.org/r/112472/diff/ > > > Testing > ------- > > Builds, works. > > > Thanks, > > Anant Kamath > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
