----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114927/#review47105 -----------------------------------------------------------
kde-workspace patch https://git.reviewboard.kde.org/r/114928/ an alternative approach would be to just not ship the dbus interface files there are a number of other solid dbus interfaces used by powerdevil, should these be named too for consistency? are there any other users of these interfaces? - Jonathan Riddell On Jan. 9, 2014, 1:48 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114927/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 1:48 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: solid > > > Description > ------- > > libsolid installs dbus interface files which have the same filename as those > from kdelibs4. Many packagers are unable to work with this. > > This proposal renames with a KF5 namespace the files installed. > > It also does not install the freedesktop dbus files, source using these will > need to bundle the files themselves. > > > Diffs > ----- > > src/solid/org.kde.KF5Solid.PowerManagement.PolicyAgent.xml PRE-CREATION > src/solid/CMakeLists.txt 0bc2abb > src/solid/org.kde.KF5Solid.Networking.Client.xml PRE-CREATION > src/solid/org.kde.Solid.Networking.Client.xml 70b46de > src/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml a07dd73 > src/solid/powermanagement.cpp 25d1ae6 > tests/CMakeLists.txt 5933708 > > Diff: https://git.reviewboard.kde.org/r/114927/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
