----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114927/#review48080 -----------------------------------------------------------
src/solid/powermanagement.cpp <https://git.reviewboard.kde.org/r/114927/#comment34034> Is this change needed? Only XML names changed, interfaces are the same (at least in this diff) Same for other changes in this file. I'd keep interfaces as they are, and only rename xml's, but that's more for Solid guys to say ;-) - Hrvoje Senjan On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114927/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 11:23 a.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: solid > > > Description > ------- > > libsolid installs dbus interface files which have the same filename as those > from kdelibs4. Many packagers are unable to work with this. > > This proposal renames with a KF5 namespace the files installed. > > It also does not install the freedesktop dbus files, source using these will > need to bundle the files themselves. > > > Diffs > ----- > > src/solid/org.kde.KF5Solid.PowerManagement.PolicyAgent.xml PRE-CREATION > src/solid/CMakeLists.txt 0bc2abb > src/solid/org.kde.KF5Solid.Networking.Client.xml PRE-CREATION > src/solid/org.kde.Solid.Networking.Client.xml 70b46de > src/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml a07dd73 > src/solid/powermanagement.cpp 25d1ae6 > tests/CMakeLists.txt 5933708 > > Diff: https://git.reviewboard.kde.org/r/114927/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
