> On Dec. 20, 2014, 8:25 a.m., Jan Grulich wrote: > > I definitely don't want to drop support for Bluez 4, it will take some time > > to get distributions use NetworkManager 1.0.0 so your patch would break it > > for those using older NM versions. > > Jan Grulich wrote: > I mean we have to support older NM versions which requires also > ModemManager to make this work. Even libnm-qt supports older NM versions. > I'll take a look properly on your patch when I have more time. > > Xuetian Weng wrote: > But think about it: > 1. network manager prior to 0.9.8 doesn't support bluez 5 dun connection. > (Fedora patches NM for 0.9.8) > 2. bluedevil in plasma 5 only works with bluez 5. (Though there's no > release yet, latest bluedevil 2.0 release can also only work with bluez 5). > 3. that function is only called from bluedevil user interface (which is > currently dropped in bluedevil because nm doesn't support it). > > Distribution who wants to use bluedevil in kf5 must use bluez 5. > opensuse use bluez 5 since 13.1 > fedora use bluez 5 since fedora 20. > arch is using bluez 5 since 2013.5. > > which means in those distribution, bluetooth dun doesn't work with NM at > all. > > The only distribution left is ubuntu, which might also use bluez 5 for > their next release http://www.phoronix.com/scan.php?page=news_item&px=MTgzNzM > . > > Is it possible to use old bluedevil that work with bluez 4 and bluez 4 on > a distribution? That means, bluedevil is not ported to kde5, and it still > uses kded4, the bluedevil kded module is not even loaded in non-kde4 > environment. Why would they package plasma 5 with such old bluez then? > > Xuetian Weng wrote: > Oh sorry, there's one small mistake: fedora's patch is for nm 0.9.10, > here's the report https://bugzilla.redhat.com/show_bug.cgi?id=1055628. > > Jan Grulich wrote: > Add please Lukáš Tinkl and Lamarque Souza to reviewers.
Weng has a point. Only Bluedevil uses this code, if there is a Bluez 5 and Plasma 5 version of Bluedevil available then it makes sense to drop support for Bluez 4. Let's face it this code is a kind of horrible, it needs a rewrite even. It does not support more than one bluetooth controller either, luckily for us that is not a common setup :-) Plasma 5 is not mainstream yet, there will be time for distributions to add Bluez 5 to their package suites, if they have not done so yet. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121606/#review72331 ----------------------------------------------------------- On Dec. 23, 2014, 4:26 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121606/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 4:26 p.m.) > > > Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > bluez 5 + networkmanager 1.0.0 suppose to support dun connection, bluedevil > for kf5 IMHO will support bluez 5. So this patch also drops bluez4 support > completely. > > nm 1.0.0's dun support doesn't require modemmanager AFAIK, so that part is > dropped in this patch. (Not quite sure if nap is supported or not) > > bluetoothdbustype.cpp is used because there's metatype conflict with > libnm-qt, so declare the type in a separate file to avoid this. > > > Diffs > ----- > > kded/CMakeLists.txt 910f5fa > kded/bluetoothdbustype.h PRE-CREATION > kded/bluetoothdbustype.cpp PRE-CREATION > kded/bluetoothmonitor.h 5f43369 > kded/bluetoothmonitor.cpp 3aaf701 > > Diff: https://git.reviewboard.kde.org/r/121606/diff/ > > > Testing > ------- > > qdbus org.kde.plasmanetworkmanagement /org/kde/plasmanetworkmanagement > org.kde.plasmanetworkmanagement.addBluetoothConnection [macaddress] dun can > now create connection. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
