> On Dec. 25, 2014, 11:41 a.m., Lamarque Souza wrote: > > kded/bluetoothmonitor.cpp, line 359 > > <https://git.reviewboard.kde.org/r/121606/diff/2/?file=335754#file335754line359> > > > > When I implemented support for bluetooth connection I remember Alex > > Fiestas asking me to override if there was a connection with the same > > bluetooth address. That was decided like that because Bluetooth only > > presents the dialog to activate network service for the phone right after > > the pairing process. If we do not override the connection here the user > > will have to delete the connection in Connection Managerm unpair de > > bluetooth device and pair it again. By overriding we do not force the user > > to manually delete the connection.
On the other hand nobody has complained about this change. Since it has nothing to do with your patch let's keep it. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121606/#review72500 ----------------------------------------------------------- On Dec. 25, 2014, 2:58 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121606/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2014, 2:58 a.m.) > > > Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > bluez 5 + networkmanager 1.0.0 suppose to support dun connection, bluedevil > for kf5 IMHO will support bluez 5. So this patch also drops bluez4 support > completely. > > nm 1.0.0's dun support doesn't require modemmanager AFAIK, so that part is > dropped in this patch. (Not quite sure if nap is supported or not) > > bluetoothdbustype.cpp is used because there's metatype conflict with > libnm-qt, so declare the type in a separate file to avoid this. > > > Diffs > ----- > > kded/bluetoothmonitor.cpp 3aaf701 > kded/dbus/org.freedesktop.DBus.Properties.xml PRE-CREATION > kded/dbus/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION > kded/bluetoothmonitor.h 5f43369 > kded/bluetoothdbustype.cpp PRE-CREATION > kded/CMakeLists.txt 910f5fa > kded/bluetoothdbustype.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121606/diff/ > > > Testing > ------- > > qdbus org.kde.plasmanetworkmanagement /org/kde/plasmanetworkmanagement > org.kde.plasmanetworkmanagement.addBluetoothConnection [macaddress] dun can > now create connection. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
