----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96135 -----------------------------------------------------------
Just to be clear: by doing the review, I do not change my mind. This is just for the case that the maintainer decides differently. backends/CMakeLists.txt (lines 11 - 16) <https://git.reviewboard.kde.org/r/128073/#comment64990> use feature_summary instead of messages src/doctor/CMakeLists.txt (lines 1 - 3) <https://git.reviewboard.kde.org/r/128073/#comment64991> use a proper configure file instead of adding definitions as compile flags src/doctor/doctor.cpp (line 115) <https://git.reviewboard.kde.org/r/128073/#comment64992> qCWarning instead of cerr src/doctor/doctor.cpp (lines 122 - 141) <https://git.reviewboard.kde.org/r/128073/#comment64993> what's the point of having setDpms method around if the implementation is ifdefed? src/doctor/doctor.cpp (lines 144 - 155) <https://git.reviewboard.kde.org/r/128073/#comment64994> same here - the method is pointless - Martin Gräßlin On June 1, 2016, 10:10 a.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128073/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 10:10 a.m.) > > > Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and > Sebastian Kügler. > > > Repository: libkscreen > > > Description > ------- > > Look for KF5Wayland as optional package, not building all the Wayland-related > code (backend, additions to tests, DPMS support in kscreen-doctor) if it is > not available. > > This allows libkscreen to build again on platforms without Wayland, such as > non-Linux or old Linux distros. > > > Diffs > ----- > > CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b > autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 > backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c > src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c > src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 > tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 > > Diff: https://git.reviewboard.kde.org/r/128073/diff/ > > > Testing > ------- > > Builds fine. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
