----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96137 -----------------------------------------------------------
Speaking with the maintainer's hat on: I don't want this. Here are the reasons: - We are short on manpower, adding a build option makes this worse as we now have to maintain different versions of the build - It's not going to be autotested on KDE CI - I don't have the time to tell users that they have to rebuild libkscreen with wayland enabled to fix their systems - I can't guarantee that changes we make in the future won't require wayland, and I'm not willing to invest time into making sure it still builds in both configurations I understand that for some, it's important to have no wayland deps (be these reasons valid or not), but for us it's causing more work and for the sake of our users, I'm making the call that we concentrate on bugs our users report, not on making our builds more complex, because that would achieve the opposite. So, NAK. - Sebastian Kügler On June 1, 2016, 8:10 a.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128073/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 8:10 a.m.) > > > Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and > Sebastian Kügler. > > > Repository: libkscreen > > > Description > ------- > > Look for KF5Wayland as optional package, not building all the Wayland-related > code (backend, additions to tests, DPMS support in kscreen-doctor) if it is > not available. > > This allows libkscreen to build again on platforms without Wayland, such as > non-Linux or old Linux distros. > > > Diffs > ----- > > CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b > autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 > backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c > src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c > src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 > tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 > > Diff: https://git.reviewboard.kde.org/r/128073/diff/ > > > Testing > ------- > > Builds fine. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
