> On Oct. 31, 2016, 3:40 p.m., Lamarque Souza wrote: > > src/solid/devices/CMakeLists.txt, line 117 > > <https://git.reviewboard.kde.org/r/129293/diff/1/?file=483489#file483489line117> > > > > Your patch still compiles hal even though it will not be used.
That was intended. HAL backend can still be used by Solid's clients directly. We just don't want to include it in default manager set. - Gleb ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100432 ----------------------------------------------------------- On Oct. 31, 2016, 2:25 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129293/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 2:25 p.m.) > > > Review request for Solid and Tobias Berner. > > > Repository: solid > > > Description > ------- > > While these backends can coexist, this would result in duplicated device > entries in Solid for a single real device. > > > Diffs > ----- > > src/solid/devices/CMakeLists.txt d51ebb3 > src/solid/devices/config-solid.h.cmake a68af32 > src/solid/devices/managerbase.cpp eee4de5 > > Diff: https://git.reviewboard.kde.org/r/129293/diff/ > > > Testing > ------- > > Compile. > > > Thanks, > > Gleb Popov > >
