----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129293/#review100439 -----------------------------------------------------------
src/solid/devices/CMakeLists.txt (line 98) <https://git.reviewboard.kde.org/r/129293/#comment67407> I think you should change this description to something like: "Use bsdisks/UDisks2 instead of hal to manage disk devices" - Lamarque Souza On Oct. 31, 2016, 12:58 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129293/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 12:58 p.m.) > > > Review request for Solid and Tobias Berner. > > > Repository: solid > > > Description > ------- > > While these backends can coexist, this would result in duplicated device > entries in Solid for a single real device. > > > Diffs > ----- > > src/solid/devices/CMakeLists.txt d51ebb3 > src/solid/devices/config-solid.h.cmake a68af32 > src/solid/devices/managerbase.cpp eee4de5 > > Diff: https://git.reviewboard.kde.org/r/129293/diff/ > > > Testing > ------- > > Compile. > > > Thanks, > > Gleb Popov > >
