On Thursday 05 June 2008, Michael Biebl wrote: > A few comments: > > 1.) Although it has a bz2 file ending, the tarball seems to be gzipped.
Gah! I uploaded a fixed one. > 2.) configure.in.in still lists 0.7. as version: > AM_INIT_AUTOMAKE(dbus-1-qt3, 0.7). > This version number should be bumped prior to release. It would also be > nice to have a tag in SVN. > > 3.) the tarball name (libdbus-1-qt3) and the package name (dbus-1-qt3) > differ. Usually the release tarball is named > $package_name-$version.tar.(gz,bz2). > This is e.g. how "make dist" does it. > It would be nice to know, if I should refer to the project as dbus-1-qt3 > or libdbus-1-qt3 (in my package build files) > > 4.) I tried to run make distcheck. It immediately errs out, because it > can't find Makefile.cvs. I couldn't find Makefile.cvs in EXTRA_DIST in > Makefile.am or so, so this is a bit weird. Probably one of those > KDE/auto* black magic. > It's apparent, that "make dist" wasn't used for creating the dist > tarball, otherwise 2.),3.) and 4.) couldn't have happened. > I always find "make distcheck" particularly helpful, as it catches a lot > of common packaging mistakes. > > 5.) Having an up-to-date ChangeLog / NEWS file would be really nice, to > see what has changed. > > 6.) License > COPYING only lists GPL2+ as license, but it seems *.cpp, *.h, dbus/*.h > examples/* are dual-licensed under GPL2+ and Academic Free License 2.1. > tools/dbusxml2qt3/* seems to be BSD style licensed. > Could you please clarify this situation. I will fix these other issues later this evening. Thanks for reporting! Cheers, Kevin
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
